Skip to content

fix: add quotes for scoped packages containing "@" #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2019

Conversation

vakrilov
Copy link

@vakrilov vakrilov commented Aug 29, 2019

When generating PbxGroup the name might contain "@" (ex. @nativescript/core). In this case we should add quotes to the string.

@cla-bot cla-bot bot added the cla: yes label Aug 29, 2019
@vakrilov vakrilov requested a review from KristianDD August 29, 2019 12:44
@KristianDD KristianDD merged commit 39d26b1 into master Sep 20, 2019
@vakrilov
Copy link
Author

🎉

@vakrilov vakrilov deleted the scoped-packages branch September 24, 2019 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants